Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: load policy rule without splitting custom functions #293

Merged
merged 4 commits into from
Apr 6, 2023

Conversation

flynndcs
Copy link
Contributor

@flynndcs flynndcs commented Apr 3, 2023

This PR expands #292 to support parentheses, used in custom functions (https://casbin.org/docs/function#how-to-add-a-customized-function)

@casbin-bot
Copy link
Member

@Nekotoxin please review

@flynndcs
Copy link
Contributor Author

flynndcs commented Apr 3, 2023

@hsluoyz - This change should be in line with #292, can you review?

@CLAassistant
Copy link

CLAassistant commented Apr 3, 2023

CLA assistant check
All committers have signed the CLA.

@flynndcs flynndcs force-pushed the flynn/fix-split-policy-rule branch from 37042a6 to afa3a38 Compare April 3, 2023 14:20
@hsluoyz
Copy link
Member

hsluoyz commented Apr 3, 2023

@flynndcs plz fix:

image

@flynndcs
Copy link
Contributor Author

flynndcs commented Apr 6, 2023

@hsluoyz - CLA signed, looks like the most recent checks passed except for the Semantic PR check - issue looks to be the most recent commit

@hsluoyz
Copy link
Member

hsluoyz commented Apr 6, 2023

@flynndcs can you update here:

os: [ubuntu-18.04, macOS-latest, windows-latest]
to ubuntu-latest, and change Python here:
python-version: ['3.7', '3.8', '3.9', '3.10']
to 3.8, 3.9, 3.10, 3.11 ?

@flynndcs flynndcs force-pushed the flynn/fix-split-policy-rule branch from 5ed597d to 17be63b Compare April 6, 2023 16:03
@hsluoyz hsluoyz merged commit fbc4261 into casbin:master Apr 6, 2023
12 checks passed
github-actions bot pushed a commit that referenced this pull request Apr 6, 2023
## [1.18.2](v1.18.1...v1.18.2) (2023-04-06)

### Bug Fixes

* load policy rule without splitting custom functions ([#293](#293)) ([fbc4261](fbc4261))
@github-actions
Copy link

github-actions bot commented Apr 6, 2023

🎉 This PR is included in version 1.18.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants