Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix release workflow #331

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Conversation

abichinger
Copy link
Member

@abichinger abichinger commented Oct 25, 2023

This PR should fix the failed release caused by my plugin semantic-release-pypi

First I migrated setup.py to pyproject.toml in order to put all metadata into a single file.

Here is a diff of pip show -v casbin (left: setup.py, right: pyproject.toml)

pip_show_diff

Then I added a package.json to set the semantic release version. This should prevent errors like this abichinger/semantic-release-pypi#31 to happen in the future.

@casbin-bot
Copy link
Member

@Nekotoxin please review

@abichinger
Copy link
Member Author

@leeqvip please review

Copy link
Member

@leeqvip leeqvip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@leeqvip leeqvip merged commit ad259c0 into casbin:master Oct 25, 2023
24 checks passed
@github-actions
Copy link

🎉 This PR is included in version 1.33.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants