Allow passing *redis.Client when create Watcher #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is to allow more flexibility when choosing redis client to used with Watcher, as the default option does not allow using RedisFailoverClient (Sentinel, for example Signed-off-by: Binh Nguyen <binh.d.nguyen165@gmail.com>
|
@binhnguyenduc hi, please fix:
|
kilosonc
requested changes
Jun 10, 2021
Comment on lines
+61
to
+71
| if option.SubClient != nil { | ||
| w.subClient = option.SubClient | ||
| } else { | ||
| w.subClient = rds.NewClient(&option.Options) | ||
| } | ||
| if option.PubClient != nil { | ||
| w.pubClient = option.PubClient | ||
| } else { | ||
| w.pubClient = rds.NewClient(&option.Options) | ||
| } | ||
|
|
There was a problem hiding this comment.
plz move this part into initConfig, and format the code
|
Replaced by: #15 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #13
The current default implementation create a new redis.Client based on the Addr. This limits the options when it comes to which redis Client to use, i.e. will not be able to use redis.FailoverClient in Sentinel mode.
I made a small change to allow caller to pass in already initialized redis.Client to the Watcher.