Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixed save policy for concurrent #27

Merged
merged 1 commit into from
Jun 11, 2020
Merged

fixed save policy for concurrent #27

merged 1 commit into from
Jun 11, 2020

Conversation

linxing
Copy link
Contributor

@linxing linxing commented Jun 11, 2020 •
edited by hsluoyz

I am not quite understand why not just CRUD the policy when save policy instead of drop table then create table?

Fix: #26

@coveralls
Copy link

Coverage Status

Coverage increased (+0.9%) to 67.713% when pulling ce86dd4 on linxing:fix-save-policy into 79a2aa5 on casbin:master.

@linxing linxing mentioned this pull request Jun 11, 2020
Closed
@hsluoyz hsluoyz merged commit bf0e598 into casbin:master Jun 11, 2020
@hsluoyz hsluoyz mentioned this pull request Jun 11, 2020
Closed
@hsluoyz
Copy link
Member

hsluoyz commented Jun 11, 2020

This PR is reverted because of this: #28 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adapter.SavePolicy() not safe for concurrent use?
3 participants
@linxing @coveralls @hsluoyz