Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Python Plugin system for extending Virtue and add a CLI for installing the Virtue SKILL environment into a Python environment #18

Merged
merged 5 commits into from Aug 15, 2022

Conversation

curtisma
Copy link
Contributor

@curtisma curtisma commented Aug 15, 2022

Description

Closes #17

Added the ability to extend Virtue using Python plugins by using pluggy.
It also added a

How Has This Been Tested?

Note: Please include unit tests and integration tests that cover the update. The unit tests should be fast (ms) and the integration tests should be representative of real use cases.

The CLI was tested locally and unit tests were added for both the API and CLI.

Checklist:

  • I linked the issues it addresses
    • a pull request should have 1-3 linked issues
  • I have assigned at least 1 reviewer
  • I have applied appropriate labels
  • I have assigned it to a milestone
  • I have assigned it to a project
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked my code and corrected any misspellings

@curtisma curtisma added documentation Improvements or additions to documentation enhancement New feature or request minor release labels Aug 15, 2022
@curtisma curtisma self-assigned this Aug 15, 2022
@curtisma curtisma changed the title Curtisma/issue17 Add a Python Plugin system for extending Virtue and add a CLI for installing the Virtue SKILL environment into a Python environment Aug 15, 2022
@curtisma curtisma merged commit 06724fd into main Aug 15, 2022
@curtisma curtisma deleted the curtisma/issue17 branch August 15, 2022 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for SKILL environment initialization using a Python plug-in system
1 participant