Skip to content

Commit

Permalink
chore(ci): add linter the check go code style (#991)
Browse files Browse the repository at this point in the history
* feat(ci): auto format go code

* fix: fix #997

* chore(ci): add go code style linter

* fix: fix cmd error

* chore: add `linter` of needs

* chore: modiy commnet style
  • Loading branch information
qianxi0410 committed Aug 13, 2022
1 parent a741c51 commit 108fdc1
Show file tree
Hide file tree
Showing 4 changed files with 27 additions and 6 deletions.
21 changes: 20 additions & 1 deletion .github/workflows/build.yml
Expand Up @@ -57,11 +57,30 @@ jobs:
go build -race -ldflags "-extldflags '-static'"
working-directory: ./

linter:
name: Go-Linter
runs-on: ubuntu-latest
needs: [ go-tests ]
steps:
- uses: actions/checkout@v3
- uses: actions/setup-go@v3
with:
go-version: '^1.16.5'

# gen a dummy config file
- run: touch dummy.yml

- name: golangci-lint
uses: golangci/golangci-lint-action@v3
with:
version: latest
args: --disable-all -c dummy.yml -E=gofumpt --max-same-issues=0 --timeout 5m --modules-download-mode=mod

release-and-push:
name: Release And Push
runs-on: ubuntu-latest
if: github.repository == 'casdoor/casdoor' && github.event_name == 'push'
needs: [ frontend, backend ]
needs: [ frontend, backend, linter ]
steps:
- name: Checkout
uses: actions/checkout@v2
Expand Down
2 changes: 1 addition & 1 deletion .golangci.yml
Expand Up @@ -31,7 +31,7 @@ run:
- api
# skip-files:
# - ".*_test\\.go$"
modules-download-mode: vendor
modules-download-mode: mod
# all available settings of specific linters
linters-settings:
lll:
Expand Down
1 change: 1 addition & 0 deletions conf/conf_test.go
Expand Up @@ -11,6 +11,7 @@
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
// See the License for the specific language governing permissions and
// limitations under the License.

package conf

import (
Expand Down
9 changes: 5 additions & 4 deletions controllers/token.go
Expand Up @@ -269,10 +269,11 @@ func (c *ApiController) TokenLogout() {
// IntrospectToken
// @Title IntrospectToken
// @Description The introspection endpoint is an OAuth 2.0 endpoint that takes a
// parameter representing an OAuth 2.0 token and returns a JSON document
// representing the meta information surrounding the
// token, including whether this token is currently active.
// This endpoint only support Basic Authorization.
// parameter representing an OAuth 2.0 token and returns a JSON document
// representing the meta information surrounding the
// token, including whether this token is currently active.
// This endpoint only support Basic Authorization.
//
// @Param token formData string true "access_token's value or refresh_token's value"
// @Param token_type_hint formData string true "the token type access_token or refresh_token"
// @Success 200 {object} object.IntrospectionResponse The Response object
Expand Down

0 comments on commit 108fdc1

Please sign in to comment.