fix: fix the No.0 bug(for all sign up methods) (#535)

casdoor · Mar 4, 2022 · 4d48517 · 4d48517
1 parent 178cf79
commit 4d48517
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 3 deletions.
diff --git a/controllers/account.go b/controllers/account.go
@@ -149,8 +149,6 @@ func (c *ApiController) Signup() {
 		username = id
 	}
 
-	userCount := object.GetUserCount(form.Organization, "", "") + 1
-
 	user := &object.User{
 		Owner:             form.Organization,
 		Name:              username,
@@ -173,7 +171,6 @@ func (c *ApiController) Signup() {
 		IsDeleted:         false,
 		SignupApplication: application.Name,
 		Properties:        map[string]string{},
-		Ranking:           userCount + 1,
 		Karma:             0,
 	}
 

diff --git a/object/user.go b/object/user.go
@@ -352,6 +352,8 @@ func AddUser(user *User) bool {
 
 	user.PermanentAvatar = getPermanentAvatarUrl(user.Owner, user.Name, user.Avatar)
 
+	user.Ranking = GetUserCount(user.Owner, "", "") + 1
+
 	affected, err := adapter.Engine.Insert(user)
 	if err != nil {
 		panic(err)