feat: fix SSRF when download avatar #1193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@seriouszyx @ComradeProgrammer @Resulte please review |
Nash-x9
suggested changes
Oct 8, 2022
There was a problem hiding this comment.
In my opinion, filtering Intranet addresses does reduce the vulnerability damage, but risks still exist. For example, if you use this function to brush the number of clicks and bypass the CDN to obtain the real IP address of the server, the service of downloading profile pictures by the server needs to be sorted out and discussed, rather than simply filtering.
|
Now fixed by modifying the |
leo220yuyaodog
requested review from
Nash-x9
and removed request for
seriouszyx,
Resulte and
ComradeProgrammer
|
🎉 This PR is included in version 1.136.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #1187
Restrict the Intranet ip when download for syncing permanent avatar
Plz review @gregxsunday