Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Send-code-button-should-be-gray-out-with-empty-or-invalid-Email… #129

Merged
merged 1 commit into from
Jun 24, 2021
Merged

feat: Send-code-button-should-be-gray-out-with-empty-or-invalid-Email… #129

merged 1 commit into from
Jun 24, 2021

Conversation

sh1luo
Copy link
Contributor

@sh1luo sh1luo commented Jun 23, 2021

Fix: #110
Signed-off-by: wasabi 690898835@qq.com

@sh1luo
Copy link
Contributor Author

sh1luo commented Jun 23, 2021

demo link: http://testb.rescld.cn/signup

Have to be aware of is that the regular expression of email comes from the source code of antd(https://github.com/yiminghe/async-validator/blob/057b0b047f88fac65457bae691d6cb7c6fe48ce1/src/rule/type.ts#L9)

the regular expression of phone comes from here

web/src/auth/SignupPage.js Outdated Show resolved Hide resolved
web/src/auth/SignupPage.js Outdated Show resolved Hide resolved
web/src/auth/SignupPage.js Outdated Show resolved Hide resolved
…-or-phone

Signed-off-by: wasabi <690898835@qq.com>
@hsluoyz hsluoyz merged commit 8b8eeea into casdoor:master Jun 24, 2021
@sh1luo sh1luo deleted the feat-Send-code-button-should-be-gray-out-with-empty-or-invalid-Email-or-phone branch June 29, 2021 13:01
@hsluoyz
Copy link
Member

hsluoyz commented Aug 11, 2021

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@casbin-bot
Copy link
Contributor

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Send code button should be gray-out with empty or invalid Email or phone
3 participants