fix: version cannot be displayed in docker image #2993
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tangyang9464 @imp2002 please review |
|
|
|
"runmode" is mostly useless, we don't use it in such scenario. |
|
@seeleclover as an advice, discuss with the community first before making a PR, to save your time |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: #2981
I think this interface should determine which method to use to obtain the version based on the
runmodeinconf/app.conf. If it isdev, then obtain the version through Git History; If it isprod, then obtain the version throughversion_info.txt.If users run Casdoor through compilation and in
Production Mode, they should be required to generateversion_info.txtaftergo build. I also create a PR in the Git repository of the Casdoor Document.