Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add organizations field to support synchronization of multi-organization users #3005

Closed
wants to merge 9 commits into from

Conversation

Bsheepcoder
Copy link
Contributor

@Bsheepcoder Bsheepcoder commented Jun 13, 2024

Fix : #2891

@casbin-bot
Copy link
Contributor

@tangyang9464 @imp2002 please review

@Bsheepcoder Bsheepcoder changed the title feat: Syncer Multi-organization User Synchronization feat: add organizations field to support synchronization of multi-organization users Jun 14, 2024
@@ -30,7 +30,7 @@ require (
github.com/go-telegram-bot-api/telegram-bot-api v4.6.4+incompatible
github.com/go-webauthn/webauthn v0.6.0
github.com/golang-jwt/jwt/v4 v4.5.0
github.com/google/uuid v1.4.0
github.com/google/uuid v1.6.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

imho, it is unnecessary to change go.mod , it will be better to open a new pr to upgrade packages

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, i get it,thanks

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bsheepcoder not next time. It needs to be fixed "this time", or this PR will not pass

@@ -23,6 +23,7 @@
"antd": "5.2.3",
"antd-token-previewer": "^1.1.0-22",
"buffer": "^6.0.3",
"caniuse-lite": "^1.0.30001621",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this useful?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe not. I seem to have added it when executing'go mod tidy 'or other commands. I'll pay attention next time.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bsheepcoder not next time. It needs to be fixed "this time", or this PR will not pass

errCh := make(chan error, len(owners))

for _, owner := range owners {
owner := owner // 创建局部变量,避免闭包中的问题
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All English

@@ -30,7 +30,7 @@ require (
github.com/go-telegram-bot-api/telegram-bot-api v4.6.4+incompatible
github.com/go-webauthn/webauthn v0.6.0
github.com/golang-jwt/jwt/v4 v4.5.0
github.com/google/uuid v1.4.0
github.com/google/uuid v1.6.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Bsheepcoder not next time. It needs to be fixed "this time", or this PR will not pass

@@ -100,6 +106,9 @@ class SyncerEditPage extends React.Component {

const syncer = this.state.syncer;
syncer[key] = value;
if (key === "organization") {
syncer.organizations = []; // 清空 organizations 字段
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All English

@@ -5623,6 +5623,11 @@ caniuse-lite@^1.0.0, caniuse-lite@^1.0.30001464, caniuse-lite@^1.0.30001503:
resolved "https://registry.yarnpkg.com/caniuse-lite/-/caniuse-lite-1.0.30001507.tgz#fae53f6286e7564783eadea9b447819410a59534"
integrity sha512-SFpUDoSLCaE5XYL2jfqe9ova/pbQHEmbheDf5r4diNwbAgR3qxM9NQtfsiSscjqoya5K7kFcHPUQ+VsUkIJR4A==

caniuse-lite@^1.0.30001621:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not next time. It needs to be fixed "this time", or this PR will not pass

@@ -297,6 +297,7 @@
"Organization": "Organization",
"Organization - Tooltip": "Similar to concepts such as tenants or user pools, each user and application belongs to an organization",
"Organizations": "Organizations",
"Organizations - Tooltip": "Provides multi-organization synchronization capabilities",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just don't update i18n

@hsluoyz
Copy link
Member

hsluoyz commented Jun 15, 2024

Closed for now

@hsluoyz hsluoyz closed this Jun 15, 2024
@Bsheepcoder Bsheepcoder deleted the master branch June 17, 2024 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sync without fill owner by casdoor
4 participants