-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: fix OIDC address field #3013
Conversation
@tangyang9464 @imp2002 please review |
@dacongda plz review |
🎉 This PR is included in version 1.632.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Reverted due to severe bug |
Are there any plans to fix it again properly? Cannot integrate with PhotoPrism due to this bug. |
Set the application's JWT type to JWT-Empty might temporarily solve your problem, if it work or not, please reply |
Fix: #3001
OIDC : https://openid.net/specs/openid-connect-core-1_0-errata2.html#AddressClaim
I test with go-oidc,test result:
![image](https://private-user-images.githubusercontent.com/73925108/341856585-dbdddb6b-7bf0-4a5b-9636-7799b7e41b33.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjE2NTY5NzQsIm5iZiI6MTcyMTY1NjY3NCwicGF0aCI6Ii83MzkyNTEwOC8zNDE4NTY1ODUtZGJkZGRiNmItN2JmMC00YTViLTk2MzYtNzc5OWI3ZTQxYjMzLnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNDA3MjIlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjQwNzIyVDEzNTc1NFomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWFmMzE4YjU4MDE1OWY4NTUzNzYxN2E2ZWE1YjFkOTgxODk0ZDExNWYwMWI0OWU4ZGY3MjgwYTIxY2NiZjYxMjImWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0JmFjdG9yX2lkPTAma2V5X2lkPTAmcmVwb19pZD0wIn0.h-kSw_2cSwCEvdD1q94AUhOzsMqyNMOyAL8ZSmFHqEs)
go-oidc key code: