Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A mistake in ecorec.py #31

Closed
814734522 opened this issue Apr 19, 2019 · 2 comments
Closed

A mistake in ecorec.py #31

814734522 opened this issue Apr 19, 2019 · 2 comments

Comments

@814734522
Copy link

814734522 commented Apr 19, 2019

arthur,i had readed the paper about the corec.py,And had found the code is differnt with the paper.the items which each users hasn't viewed wasn't selected randomly. the code was in ecorec.py line 135,it just shuffle the unlable_set,not to select items randomly. And i had to run the ecorec.py the result was bad .Is there something I haven't done batter?(for exmple,data normalize or other?)

@814734522 814734522 reopened this Apr 21, 2019
@arthurfortes
Copy link
Member

arthurfortes commented Apr 21, 2019

The actual implementation of the repository is not the same as the article (randomness of data, confidence measures and some other details). As soon as possible, I will upload a new version of the framework with these and other changes. The pip version is also out of date, in which CoRec does not even work yet.

@814734522
Copy link
Author

814734522 commented Apr 21, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants