Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Including Non-negative Matrix Factorization and fixing RatingPredictionEvaluation #27

Merged
merged 6 commits into from
Jan 22, 2019

Conversation

guedes-joaofelipe
Copy link
Contributor

The NMF was added as a rating prediction algorithm, similar to SVD. Also, whenever evaluating a rating-prediction recommender with item-recommendation metric using the evaluate_recommender method, the result would only be printed. A modification was made in order to return such evaluations, followed by an extra example in the 'examples' folder. Finally, comments were included to improve readability.

…evaluate_recommender

The evaluate_recommender method would only print on the screen an item-based metric performed on rating-prediction-based algorithm, making the return of the evaluate_recommender method and empty dict. An example of utilization was added to the examples folder
@arthurfortes
Copy link
Member

Hi, @guedes-joaofelipe!

I appreciate your collaboration and your effort to extend this framework. I'm reviewing your commit and I need to ask you some changes:

Remove or put in gitignore

  • Folders: /pycache/
  • Files: *.pyc
  • .ipynb

I'm not using notebook yet for exemplify the use of recommenders. So if you want to keep your notebook, please create a folder in '/examples/', called notebooks and insert your material. Please not save the checkpoints.

One more time, I want to thanks for your help to improve Case Recommender.

@arthurfortes arthurfortes merged commit 9ba8abf into caserec:master Jan 22, 2019
@arthurfortes
Copy link
Member

Merged!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants