-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
completions::bash
test failing under Alpine since 1.28.0
#2325
Comments
Thanks for reporting this! Do master and the latest released version, 1.34, fail with the same error? That test tries to interactively make sure that bash completions are working, so it's probably sensitive to which version of bash is installed. |
The error building 1.34.0 appears in the middle of the test output rather than the end, but other than that is identical:
I think it's just due to Rust parallelism and waiting for all jobs to finish. I'm not sure how to build from master unfortunately due to the way abuild works. The bash version in use is shown while setting up the environment as I tried manually running the build in the build environment, and then manually running the test:
Maybe something related to temp file handling when running in abuild? I'm starting to think we can disable this test like the three others already disabled for Alpine builds, the output itself is correct I think. |
Hmm, interesting. Can you try with an older version of bash? The tests are passing for me on a Debian box with bash 5.1.4. |
It's really difficult to inject packages from older releases of Alpine during the build process unfortunately. I think I'll just add it to the skipped tests with a brief explanation, given that I was able to pass the test successfully by running it manually. We can add it to the (for now) short list of tests that don't work on Alpine for whatever reason, and someone with more skill with abuild can maybe resolve them one day:
Is that ok with you, should I go ahead and open a MR and see what the Alpine maintainers think about it? |
That sounds pretty reasonable to me! I think this is something going on with Alpine, since tests are passing on other Linux distros, so there's probably not much to do on the |
Hi, I started using
just
recently and absolutely love it. I'm trying to update the package for Alpine to the latest, since it is currently at 1.26.0. I'm able to build 1.27.0, but 1.28.0 fails with the following error during tests:I suspect it is probably related to #2104 or #2120, unless that .git error is the underlying cause? Thought I would post here to see if anyone has come across this before digging deeper. My APKBUILD file for 1.28.0 currently looks like this:
Thanks for any help!
The text was updated successfully, but these errors were encountered: