error: reword sh to platform-neutral "shell command"
#1002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
casey
reviewed
Oct 18, 2021
Co-authored-by: Casey Rodarmor <casey@rodarmor.com>
|
Done, Now you have done all the work :) |
|
Merging! This is still a huge improvement, and wouldn't have happened without your initiative. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A simple workaround for #412, to avoid confusion on Windows without
sh. It's a hint to look upshellvariable, instead of trying to find a UNIXshimplementation.There's no existing test with this text, and I tried making some with
not-a-commandinshell,x:=\``, and recipe. But they are platform-specific too, and changes depending on whether I have busybox utils in PATH or not. So I have left them out for this PR.