Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify minimum rust version #1496

Merged
merged 5 commits into from Jan 12, 2023
Merged

Specify minimum rust version #1496

merged 5 commits into from Jan 12, 2023

Conversation

benmoss
Copy link
Contributor

@benmoss benmoss commented Jan 11, 2023

1.63 is required by Mutex::new added in #1442

Sorta fixes #1495 ? Doesn't really fix it, but makes it more clear to users that they're not gonna have a good time :)

Example of the error Cargo gives:

error: package just v1.11.0 (/workspace) cannot be built because it requires rustc 1.63 or newer, while the currently active rustc version is 1.62.1

It's not super clear at first glance but rust-version is just a minimum:

If the currently selected version of the Rust compiler is older than the stated version, cargo will exit with an error, telling the user what version is required.

1.63 is required by Mutex::new added in casey#1442
@benmoss
Copy link
Contributor Author

benmoss commented Jan 11, 2023

Maybe can do something fancy with https://crates.io/crates/cargo-msrv to do something in CI to keep this in sync

Copy link
Owner

@casey casey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that cargo-msrv is just too slow to run on CI. I think keeping the MSRV in sync manually is probably the best option.

@casey casey enabled auto-merge (squash) January 12, 2023 06:43
@casey casey merged commit b29f72c into casey:master Jan 12, 2023
@benmoss benmoss deleted the min-rust-version branch January 12, 2023 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cargo install fails with latest on Ubuntu 22.04
2 participants