Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github uses actions/cache@v2 #742

Merged
merged 1 commit into from
Jan 7, 2021
Merged

github uses actions/cache@v2 #742

merged 1 commit into from
Jan 7, 2021

Conversation

zyctree
Copy link
Contributor

@zyctree zyctree commented Jan 7, 2021

https://github.com/actions/cache/blob/main/examples.md#rust---cargo

but the cache in windows still cannot work, seems actions/toolkit#670 could fix it, need to wait github to bump a new version to include this fix

@casey
Copy link
Owner

casey commented Jan 7, 2021

Thanks for this PR! Does the actions/cache@v1 work in Windows, or is it newly broken in v2?

@zyctree
Copy link
Contributor Author

zyctree commented Jan 7, 2021

actions/cache@v1 is broken in Windows

from the output of the last action job, https://github.com/casey/just/runs/1546397193?check_suite_focus=true,

Post job cleanup.
"C:\Program Files\Git\usr\bin\tar.exe" -cz -f D:\a\_temp\d43ac80a-b321-468c-9777-c01c94d9a40b\cache.tgz -C C:\Users\runneradmin\.cargo\registry
~\.cargo\git
target .
/usr/bin/tar: ~.cargogit: Cannot stat: No such file or directory
/usr/bin/tar: target: Cannot stat: No such file or directory
tar (child): Cannot connect to D: resolve failed
/usr/bin/tar: D\:\\a\\_temp\\d43ac80a-b321-468c-9777-c01c94d9a40b\\cache.tgz: Cannot write: Broken pipe
/usr/bin/tar: Child returned status 128
/usr/bin/tar: Error is not recoverable: exiting now

it uses actions/cache@v1 , and resolve ~.cargo\git to ~.cargogit, looks like it cannot handle \ in windows. i guess it is using linux (wsl or mingw) version of tar

@casey
Copy link
Owner

casey commented Jan 7, 2021

Gotcha, thanks for the explanation. I wasn't even aware that caching was broken on Windows!

@casey casey merged commit 9915891 into casey:master Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants