Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement four string manipulation functions #888

Merged
merged 5 commits into from
Jul 3, 2021

Conversation

terror
Copy link
Contributor

@terror terror commented Jul 3, 2021

This PR implements the following functions:

  • uppercase(s)
  • lowercase(s)
  • trim(s)
  • replace(s, from, to)

In addition, this adds support for another function variant Ternary.

@casey
Copy link
Owner

casey commented Jul 3, 2021

This looks great. The only thing this needs is documentation. I think a new subsection in the Functions of the readme would be good, titled String Manipulation.

README.adoc Outdated Show resolved Hide resolved
Co-authored-by: Casey Rodarmor <casey@rodarmor.com>
src/function.rs Outdated Show resolved Hide resolved
@casey casey enabled auto-merge (squash) July 3, 2021 19:31
@casey casey merged commit a24c86e into casey:master Jul 3, 2021
@terror terror deleted the string-manipulation-functions branch July 3, 2021 19:45
@casey
Copy link
Owner

casey commented Jul 3, 2021

Merged! Thank's for the PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants