Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Cloudflare url no https issue #40

Merged
merged 1 commit into from
Jun 17, 2021
Merged

Fixed Cloudflare url no https issue #40

merged 1 commit into from
Jun 17, 2021

Conversation

jerrychong25
Copy link
Contributor

No description provided.

@jerrychong25
Copy link
Contributor Author

@caseyscarborough @grasuth @KittyKatt @dmackerman @raboof @bsdlp @NateShoffner @mimopo @tldev @JoeNyland

Hi all, can help look this into PR?

Thank you!

@KittyKatt
Copy link
Contributor

Unfortunately, I don't have write access to this repository but this seems to make sense to me. The protcol-less URL would absolutely work in almost all cases, but if it's an asset available over HTTPS (and when you load it over HTTP, it just gets redirected to HTTPS anyways, as it should), we should just default to https:// URLs because the days of performance impacts from using SSL assets are gone.

@KittyKatt
Copy link
Contributor

@caseyscarborough Highlighting you again because I believe you are the only one with write access here.

@caseyscarborough caseyscarborough merged commit b692b50 into caseyscarborough:master Jun 17, 2021
@caseyscarborough
Copy link
Owner

caseyscarborough commented Jun 17, 2021

Apologies, I missed this when it was initially opened. Thanks @KittyKatt for the tag and thank you @jerrychong25 for the fix.

@KittyKatt
Copy link
Contributor

No problem.

@jerrychong25
Copy link
Contributor Author

Thanks @caseyscarborough and @KittyKatt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants