Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI job to validate localized strings files #201

Merged
merged 1 commit into from Jan 26, 2024

Conversation

NickEntin
Copy link
Collaborator

@NickEntin NickEntin commented Jan 26, 2024

This ensures we don't forget to update a strings file when adding new descriptions.

Copy link
Collaborator

@kruegermj kruegermj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Does this confirm that for every localized string defined in a swift file there is a matching key in a strings file?

@NickEntin
Copy link
Collaborator Author

Does this confirm that for every localized string defined in a swift file there is a matching key in a strings file?

Yep, exactly! And also that there aren't duplicate keys.

@NickEntin NickEntin merged commit e507592 into master Jan 26, 2024
8 checks passed
@NickEntin NickEntin deleted the entin/validate-strings branch January 26, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants