Make HA as configurable plugin by Blip users #116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prudhvi
force-pushed
the
prudhvi.make_ha_as_plugin
branch
4 times, most recently
from
5ef4785
to
451fe70
Compare
prudhvi
changed the title
prudhvi
force-pushed
the
prudhvi.make_ha_as_plugin
branch
3 times, most recently
from
6873106
to
dc13ee8
Compare
prudhvi
force-pushed
the
prudhvi.make_ha_as_plugin
branch
from
dc13ee8
to
f490324
Compare
ha/factory.go
Outdated
| "sync" | ||
| ) | ||
|
|
||
| type HAManagerFactory interface { |
There was a problem hiding this comment.
Remove "HA" prefix. In Go, pkg name is considered part of the full name context, so ha.ManagerFactory is the idiomatic style.
monitor/loader.go
Outdated
| @@ -7,6 +7,7 @@ import ( | |||
| "crypto/sha256" | |||
| "errors" | |||
| "fmt" | |||
| "github.com/cashapp/blip/ha" | |||
There was a problem hiding this comment.
Sort the imports:
built-in_a
built-in_b
other_a
other_b
| @@ -463,11 +464,19 @@ func (ml *Loader) makeMonitor(cfg blip.ConfigMonitor) (*Monitor, error) { | |||
| sinks = append(sinks, sink) | |||
| } | |||
|
|
|||
| // Configure the HA Manager for the monitor | |||
| var ham ha.Manager | |||
There was a problem hiding this comment.
"ham" 😆 This component will now officially be known as "the ham".
ha/factory.go
Outdated
| @@ -0,0 +1,51 @@ | |||
| package ha | |||
There was a problem hiding this comment.
Let's put this all in ha/ha.go since it's all closely related--one less file.
ha/factory.go
Outdated
| type defaultFactory struct { | ||
| } | ||
|
|
||
| var df = &defaultFactory{} |
There was a problem hiding this comment.
In keeping with other pkgs (iirc):
// Internal factory disabled by default (HA not used).
var f = DisabledThen put the factor Make method on disabled (so it implements both Manager and ManagerFactory interfaces).
Then in Register, use sync.Once like you did in an earlier rev to avoid having locks and such.
prudhvi
force-pushed
the
prudhvi.make_ha_as_plugin
branch
4 times, most recently
from
64f3b97
to
e0b69b7
Compare
prudhvi
force-pushed
the
prudhvi.make_ha_as_plugin
branch
from
e0b69b7
to
85fc151
Compare
daniel-nichter
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the HA Manager customizable by the users of Blip.
For Cash app multiple clusters it's more appropriate to do leader election via k8s configmap so doing this lets us choose which EKS cluster blip is enabled/authorized to collect and send metrics, when blip is running in multiple EKS clusters.