fix: buggy lock-free fast-path check #390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alecthomas
force-pushed
the
aat/fix-unnecessary-lock
branch
from
110f685
to
c188b96
Compare
jvmakine
approved these changes
Nov 14, 2023
alecthomas
force-pushed
the
aat/fix-unnecessary-lock
branch
from
c188b96
to
1cbc712
Compare
The fast-path check to short-circuit locking was buggy becaues it was statting the `Package.Binaries` slice without glob expansion. That is, it ended up statting globs like `bin/*`.
alecthomas
force-pushed
the
aat/fix-unnecessary-lock
branch
from
1cbc712
to
dc37c3c
Compare
alecthomas
added a commit
that referenced
this pull request
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The fast-path check to short-circuit locking was buggy becaues it was statting the
Package.Binariesslice without glob expansion. That is, it ended up statting globs likebin/*, resulting in frequent unnecessary locking.