fix: manual environment switching with overlapping environments #397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we deactivated previous environment after activating a new one. This meant that if both evironments shared env variables, the deactivation script would unset them for the new environment, leaving them unset. This was not issue when using shell-hooks, as those explicitly deactivate an environment before activating a new one.
For example:
```
> cat env1/bin/hermit.hcl
env = {
FOO:BAR,
}
> cat env2/bin/hermit.hcl
env = {
FOO:BAR,
}
> cd env1
> . bin/activate-hermit
Hermit environment /Users/juho/tmp/hermit-test/env1 activated
> echo $FOO
BAR
> cd ../env2
> . bin/activate-hermit
Hermit environment /Users/juho/tmp/hermit-test/env1 deactivated
Hermit environment /Users/juho/tmp/hermit-test/env2 activated
> echo $FOO
>
```
jvmakine
commented
Mar 13, 2024
| "io" | ||
| "text/template" |
There was a problem hiding this comment.
html/template was escaping single quotes, so switched to text/template
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, we deactivated previous environment after activating a new one. This meant that if both evironments shared env variables, the deactivation script would unset them for the new environment, leaving them unset. This was not issue when using shell-hooks, as those explicitly deactivate an environment before activating a new one.
For example: