Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Misk should support some concept of environments #2

Closed
JGulbronson opened this issue Dec 5, 2017 · 1 comment
Closed

Misk should support some concept of environments #2

JGulbronson opened this issue Dec 5, 2017 · 1 comment
Assignees

Comments

@JGulbronson
Copy link
Collaborator

This will be useful when determining which yaml files for parse for config, as mentioned in #1. Examples of environments are testing, staging, production, etc.

A simple implementation could just be a String that gets bound so you can inject it like

@Inject @Env String environment

Misk can provide a module that binds based of an environment variable. Alternatively a module can statically provide an environment, and then an app can select which to install.

@maniksurtani
Copy link
Member

Should they be Strings, though? Maybe an Environment interface, and the default impl could be an enum with the more common set of {DEVELOPMENT, STAGING, PRODUCTION}.

@JGulbronson JGulbronson self-assigned this Dec 5, 2017
zhxnlai pushed a commit that referenced this issue Feb 21, 2020
rainecp pushed a commit that referenced this issue Jul 24, 2023
chore: bring over latest changes in old misk repo
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants