Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pingInterval support for HttpClientsConfig #1093

Merged
merged 1 commit into from Jul 8, 2019

Conversation

jjestrel
Copy link
Contributor

@jjestrel jjestrel commented Jul 8, 2019

No description provided.

@jjestrel jjestrel requested review from swankjesse and adrw July 8, 2019 21:11
@@ -26,6 +26,9 @@ class HttpClientFactory @Inject constructor(
TimeUnit.MILLISECONDS) }
config.writeTimeout?.let { builder.writeTimeout(it.toMillis(),
TimeUnit.MILLISECONDS) }
config.pingInterval?.let {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice use of let 👍

@jjestrel jjestrel merged commit 8b63627 into master Jul 8, 2019
@jjestrel jjestrel deleted the jayestrella/20190708-add-pingInterval-support branch July 8, 2019 21:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants