Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pingInterval support for HttpClientsConfig #1093

Merged
merged 1 commit into from Jul 8, 2019

Conversation

Projects
None yet
2 participants
@jjestrel
Copy link
Collaborator

commented Jul 8, 2019

No description provided.

@jjestrel jjestrel requested review from swankjesse and adrw Jul 8, 2019

@adrw

adrw approved these changes Jul 8, 2019

@@ -26,6 +26,9 @@ class HttpClientFactory @Inject constructor(
TimeUnit.MILLISECONDS) }
config.writeTimeout?.let { builder.writeTimeout(it.toMillis(),
TimeUnit.MILLISECONDS) }
config.pingInterval?.let {

This comment has been minimized.

Copy link
@adrw

adrw Jul 8, 2019

Collaborator

Nice use of let 👍

@jjestrel jjestrel merged commit 8b63627 into master Jul 8, 2019

2 checks passed

ci/circleci: java Your tests passed on CircleCI!
Details
ci/circleci: node Your tests passed on CircleCI!
Details

@jjestrel jjestrel deleted the jayestrella/20190708-add-pingInterval-support branch Jul 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.