Exclude junit4 so it stops getting accidentally imported #1122
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wesleyk
approved these changes
Jul 27, 2019
jjestrel
force-pushed
the
jayestrella/20190727-exclude-junit4
branch
6 times, most recently
from
fa88de3
to
929f24c
Compare
jjestrel
commented
Jul 28, 2019
| @@ -39,6 +39,7 @@ ext.dep = [ | |||
| "jettyWebsocketServer": "org.eclipse.jetty.websocket:websocket-server:9.4.18.v20190429", | |||
| "jettyWebsocketServlet": "org.eclipse.jetty.websocket:websocket-servlet:9.4.18.v20190429", | |||
| "jnrUnixsocket": "com.github.jnr:jnr-unixsocket:0.22", | |||
| "junit4": "junit:junit:4.12", | |||
There was a problem hiding this comment.
misk:misk needs this because okhttp mock webserver needs it
jjestrel
commented
Jul 28, 2019
| import java.io.ByteArrayOutputStream | ||
| import java.security.GeneralSecurityException | ||
|
|
||
| @MiskTest(startService = true) | ||
| class CryptoModuleTest { | ||
| @Suppress("unused") | ||
| @MiskTestModule | ||
| val module = CryptoTestModule() |
There was a problem hiding this comment.
This test was broken for injection the whole time
jjestrel
commented
Jul 28, 2019
| @@ -37,7 +37,12 @@ internal class AssertExtensionsTest { | |||
| } | |||
| """) | |||
| }).hasMessage( | |||
| """expected:<"{ "my_structure[]" : [ "this" , 45, "...> but was:<"{ "my_structure[2]" : [ "this" , 45, "...>""") | |||
There was a problem hiding this comment.
These messages are different in junit5
jjestrel
commented
Jul 28, 2019
| @@ -54,4 +54,5 @@ dependencies { | |||
| testCompile dep.kotlinxCoroutines | |||
| testCompile dep.mockitoCore | |||
| testCompile project(':misk-testing') | |||
| testImplementation dep.junit4 | |||
There was a problem hiding this comment.
implementation so we don't leak this dependency transitively
jjestrel
force-pushed
the
jayestrella/20190727-exclude-junit4
branch
from
929f24c
to
b811831
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think using
implementationalso fixes this but that's a bigger change.People have been accidentally importing the wrong
@Testwhich leads to injection stuff not getting set up which is a very confusing error message