Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Redis.hincrBy #2269

Merged
merged 3 commits into from Feb 2, 2022
Merged

Implement Redis.hincrBy #2269

merged 3 commits into from Feb 2, 2022

Conversation

szabado
Copy link
Collaborator

@szabado szabado commented Feb 1, 2022

No description provided.

szabado
szabado commented Feb 1, 2022
View reviewed changes
misk-redis/src/main/kotlin/misk/redis/FakeRedis.kt
if (!keyValueStore.containsKey(key)) {
return false
}
synchronized(lock) {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added this lock usage because it seemed important to avoid any concurrency errors

@szabado szabado marked this pull request as ready for review February 1, 2022 19:52
@szabado szabado merged commit 8d18dac into master Feb 2, 2022
@szabado szabado deleted the szabado/hincrby branch February 2, 2022 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r3mariano r3mariano r3mariano approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@szabado @r3mariano