Improves handling timeout/reset connection when reading request #2279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Improves exception reporting when we failed to read a request stream * Creates RequestBodyException to wrap jetty exception when reading a request
acostama
reviewed
Feb 10, 2022
| @@ -241,6 +279,30 @@ class Http2ConnectivityTest { | |||
| } | |||
| } | |||
|
|
|||
| class LockInterceptor constructor(val queue: ArrayBlockingQueue<Int>) : NetworkInterceptor { | |||
There was a problem hiding this comment.
don't remember exactly but do we still need this?
There was a problem hiding this comment.
yeah, this so the test can know when they can assert the side effect on the server side after the timeout.
acostama
approved these changes
Feb 10, 2022
swankjesse
approved these changes
Feb 10, 2022
| "unknown", | ||
| "500" | ||
| ).get().count.toInt() | ||
| ).isEqualTo(1) | ||
| } | ||
|
|
||
| /** Confirm we don't page oncall and we record a 499 in the metrics. **/ | ||
| @Test | ||
| fun clientTimeoutWritingTheRequest() { |
There was a problem hiding this comment.
I think there might be value in keeping the old test, clientTimeoutWritingTheRequest, and adding a new one like clientCancelsWritingTheRequest(). The body of the new test should be what you have here, and the body of the timeout test should be what was here before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
request