Move ActionScope and related code to :misk-action-scopes #2301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shellderp
reviewed
Mar 2, 2022
| @@ -36,7 +35,7 @@ class TestActionScopedProviderModule : ActionScopedProviderModule() { | |||
| ) : ActionScopedProvider<String> { | |||
| override fun get(): String { | |||
| val seedData = seedData.get() | |||
| if (seedData == "unauthenticated") throw UnauthenticatedException() | |||
| if (seedData == "illegal-state") throw IllegalStateException() | |||
There was a problem hiding this comment.
ah this changed because Unauthenticated is in misk-actions. got it
shellderp
approved these changes
Mar 2, 2022
swankjesse
approved these changes
Mar 2, 2022
adrw
approved these changes
Mar 2, 2022
mmollaverdi
added a commit
to mmollaverdi/misk
that referenced
this pull request
Mar 5, 2022
A recent PR, pulled the ActionScoped class out of the misk-actions subproject into a new misk-action-scopes subproject. This was a breaking change for any repositories having a dependency on misk-actions and using ActionScoped. cashapp#2301 This commit adds an api dependency in misk-actions to misk-action-scopes, so that the misk-actions package included the classes from that dependency.
swankjesse
pushed a commit
that referenced
this pull request
Mar 7, 2022
A recent PR, pulled the ActionScoped class out of the misk-actions subproject into a new misk-action-scopes subproject. This was a breaking change for any repositories having a dependency on misk-actions and using ActionScoped. #2301 This commit adds an api dependency in misk-actions to misk-action-scopes, so that the misk-actions package included the classes from that dependency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The ActionScope code provides a nice way for applications and components to get contextual information based on incoming requests, job data, etc. It would be great to publish it as a separate library, so that we don't have to pull in all of Misk to use it.