Don't check for migrations on Vitess yet #654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tirsen
commented
Nov 20, 2018
| import misk.logging.getLogger | ||
| import misk.resources.ResourceLoader | ||
| import org.hibernate.SessionFactory | ||
| import org.hibernate.query.Query | ||
| import java.sql.Connection | ||
| import java.util.* |
There was a problem hiding this comment.
I assume we don't want to wildcard import right? Or do we alllow this in Kotlin?
There was a problem hiding this comment.
I don't think so, I think some folks don't have the same java import rules setup for Kotlin in IntelliJ (myself included until recently).
|
Rebasing off Master should restore green CI builds. |
tirsen
force-pushed
the
jontirsen/2018-11-20/no-migration-check-vitess
branch
from
fd5b392
to
c486a9c
Compare
wesleyk
approved these changes
Nov 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.