Start Vitess when starting server in DEVELOPMENT environment #699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tirsen
force-pushed
the
jontirsen/2018-12-10/start-vt-in-dev
branch
from
8339d31
to
bff2508
Compare
swankjesse
approved these changes
Dec 12, 2018
|
|
||
| @Qualifier | ||
| @Target(AnnotationTarget.FIELD, AnnotationTarget.FUNCTION) | ||
| annotation class Movies |
There was a problem hiding this comment.
note to self: rename this to MoviesDb
misk-hibernate/src/main/kotlin/misk/vitess/StartVitessService.kt
Outdated
Show resolved
Hide resolved
| println("java.io.tmpdir = ${System.getProperty("java.io.tmpdir")}") | ||
| // We can't use Files::createTempDirectory because it creates a directory under the path | ||
| // /var/folders that is not possible to mount in Docker | ||
| schemaDir = Paths.get("/tmp/vitess_schema_${System.currentTimeMillis()}") |
There was a problem hiding this comment.
if you’re trying to be unique, inject a TokenGenerator. currentTimeMillis() isn’t unique enough!
There was a problem hiding this comment.
Because VitessClusters are cached globally it's very awkward to inject into them. This will be sufficiently unique for our purposes I believe. Very rarely does a developer start more than a single cluster at exactly the same millisecond.
misk-hibernate/src/main/kotlin/misk/vitess/StartVitessService.kt
Outdated
Show resolved
Hide resolved
misk-hibernate/src/main/kotlin/misk/vitess/StartVitessService.kt
Outdated
Show resolved
Hide resolved
misk-hibernate/src/main/kotlin/misk/vitess/StartVitessService.kt
Outdated
Show resolved
Hide resolved
| * Copy the resource to the specified filename [destination], creating all of the parent | ||
| * directories if necessary. | ||
| */ | ||
| private fun copyResource(address: String, destination: Path) { |
|
Love it! |
tirsen
force-pushed
the
jontirsen/2018-12-10/start-vt-in-dev
branch
2 times, most recently
from
39b2faa
to
f5e8913
Compare
tirsen
force-pushed
the
jontirsen/2018-12-10/start-vt-in-dev
branch
from
f5e8913
to
f094fbc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.