Refactor out hibernate query limits into dependency to speed up ReflectionQueryFactoryTest #763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanhall07
approved these changes
Feb 7, 2019
adrw
approved these changes
Feb 7, 2019
| transacter.transaction { session -> | ||
| for (i in 3101..10100) { | ||
| for (i in 32..41) { |
There was a problem hiding this comment.
Were any of these tests (that have been significantly reduced in quantity) the stress testing ones that had been mentioned in discussions? If so, should we have a way to still run them periodically (say daily) but not on every build / PR?
There was a problem hiding this comment.
The intention of these aren't to stress test, they're to see that the various logs are outputted
There was a problem hiding this comment.
(I wouldn't consider 10K to necessarily be "stress testing" anyways)
…ctionQueryFactoryTest
hamdanjaveed
approved these changes
Feb 7, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.