Dont bind Vitess scale checks if not using Vitess #891
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanhall07
approved these changes
Apr 1, 2019
wesleyk
reviewed
Apr 1, 2019
| @@ -50,7 +51,7 @@ class HibernateTestingModule( | |||
| qualifier = qualifier, | |||
| config = configProvider.get(), | |||
| transacterProvider = transacterProvider, | |||
| checks = checks, | |||
| checks = if (useVitessChecks) checks else null, | |||
There was a problem hiding this comment.
checks is a confusing name for something that's vitess specific. Could we rename this to the full vitessScaleSafetyChecks?
wesleyk
approved these changes
Apr 1, 2019
dhanji
force-pushed
the
dhanji/dont-bind-vitess-checks
branch
from
b24d30c
to
0cbe172
Compare
|
If this PR is still relevant, then please fix conflicts, rebase and get a green CI build. This PR will be closed at the end of January 2021 otherwise. |
|
Closing request as per previous announcement. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.