Add DisplayLinkClock for iOS, tvOS, and macOS #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevincianfarini
commented
Jan 21, 2023
kevincianfarini
commented
Jan 21, 2023
molecule-runtime/src/macosMain/kotlin/app/cash/molecule/DisplayLinkClock.kt
Show resolved
Hide resolved
kevincianfarini
commented
Jan 21, 2023
molecule-runtime/src/quartzCoreMain/kotlin/app/cash/molecule/DisplayLinkClock.kt
Show resolved
Hide resolved
kevincianfarini
commented
Jan 21, 2023
molecule-runtime/src/quartzCoreMain/kotlin/app/cash/molecule/DisplayLinkClock.kt
Show resolved
Hide resolved
JakeWharton
reviewed
Jan 23, 2023
molecule-runtime/src/quartzCoreMain/kotlin/app/cash/molecule/DisplayLinkClock.kt
Outdated
Show resolved
Hide resolved
kevincianfarini
force-pushed
the
kcianfarini/display-link-clock
branch
from
067aa76
to
a7aa8f4
Compare
|
@JakeWharton this PR is ready for a real review now. One thing to note -- The current |
|
To anyone watching this from the outside (because I keep linking it to people), we are going to merge, but are in the process of adding unit tests for iOS and tvOS. |
|
FYI, I borrowed some of this for Redwood. |
kevincianfarini
commented
Apr 27, 2023
Comment on lines
+28
to
+31
| private val displayLink: CADisplayLink = CADisplayLink.displayLinkWithTarget( | ||
| target = this, | ||
| selector = NSSelectorFromString(this::tickClock.name), | ||
| ) |
There was a problem hiding this comment.
I'm looking at this again months later and this doesn't need a variable. It can just be in an init block 🤦
This commit adds two imlementations of a `MonotonicFrameClock` backed by `CADisplayLink` on iOS and tvOS and `CVDisplayLink` on macOS. watchOS does not have an equivalent that I'm aware of and therefore has been omitted.
JakeWharton
force-pushed
the
kcianfarini/display-link-clock
branch
from
fb72f01
to
76d653e
Compare
JakeWharton
force-pushed
the
kcianfarini/display-link-clock
branch
from
76d653e
to
14390c0
Compare
|
Woohoo! Thanks for getting this over the finish line, Jake. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds two imlementations of a
MonotonicFrameClockbacked by
CADisplayLinkon iOS and tvOS andCVDisplayLinkon macOS.
watchOS does not have an equivalent that I'm aware of and therefore
has been omitted.