Only print report path if it was generated #1137
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Paparazzi currently assumes a report will always be written which isn't the case if you're verifying or if you use a custom snapshot handler. With this change the logging only happens if a report was written. This fixes cashapp#1135
TWiStErRob
reviewed
Oct 11, 2023
| } | ||
|
|
||
| test.doLast { | ||
| val uri = reportOutputDir.get().asFile.toPath().resolve("index.html").toUri() | ||
| test.logger.log(LIFECYCLE, "See the Paparazzi report at: $uri") | ||
| val report = reportOutputDir.get().asFile.resolve("index.html") |
There was a problem hiding this comment.
It should keep using the Path API. Otherwise the link will become unclickable in IDEA.
println(file("build.gradle").toURI())
// output: file:/T:/xx/build.gradle
println(file("build.gradle").toPath().toUri())
// output: file:///T:/xx/build.gradle
There was a problem hiding this comment.
Ah, great callout. I did not realize it mattered how we got a an URI instance. Will fix.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Paparazzi currently assumes a report will always be written which isn't the case if you're verifying or if you use a custom snapshot handler. With this change the logging only happens if a report was written.
This fixes #1135