Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow not logging the paparazzi report #1135

Open
ansman opened this issue Oct 10, 2023 · 0 comments
Open

Allow not logging the paparazzi report #1135

ansman opened this issue Oct 10, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@ansman
Copy link
Contributor

ansman commented Oct 10, 2023

When applying the paparazzi plugin, it logs the following at the end of every test run:

See the Paparazzi report at: ...

This is confusing for our devs because we conditionally run our screenshot tests so the referenced file often doesn't exist. It would be great if that message was either removed or made optional in some way.
@ansman ansman added the enhancement New feature or request label Oct 10, 2023
ansman added a commit to ansman/paparazzi that referenced this issue Oct 11, 2023
@ansman
Only print report path if it was generated
ce8ae0c 
Paparazzi currently assumes a report will always be written which isn't
the case if you're verifying or if you use a custom snapshot handler.
With this change the logging only happens if a report was written.

This fixes cashapp#1135
@ansman ansman mentioned this issue Oct 11, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Only print report path if it was generated ansman/paparazzi
1 participant
@ansman