Reset logger to prevent swallowing exceptions #1309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gamepro65
requested review from
swankjesse,
BrianGardnerAtl,
jrodbx and
geoff-powell
gamepro65
commented
Feb 29, 2024
| } | ||
| } | ||
|
|
||
| @get:Rule val ignored: RuleChain = RuleChain.outerRule(expectExceptionRule).around(paparazzi) |
There was a problem hiding this comment.
Because Paparazzi throws exceptions after calling base.evaluate() we unfortunately cannot use assertThrows nor @Test(expected = ...) as they execute within Paparazzi's Statement. Instead we have to wrap Paparazzi's rule to catch its exceptions, wasn't sure a better way to achieve this.
geoff-powell
approved these changes
Feb 29, 2024
jrodbx
approved these changes
Feb 29, 2024
...gin/src/test/projects/compose/src/test/java/app/cash/paparazzi/plugin/test/LoggerLeakTest.kt
Outdated
Show resolved
Hide resolved
...gin/src/test/projects/compose/src/test/java/app/cash/paparazzi/plugin/test/LoggerLeakTest.kt
Outdated
Show resolved
Hide resolved
...gin/src/test/projects/compose/src/test/java/app/cash/paparazzi/plugin/test/LoggerLeakTest.kt
Outdated
Show resolved
Hide resolved
...gin/src/test/projects/compose/src/test/java/app/cash/paparazzi/plugin/test/LoggerLeakTest.kt
Outdated
Show resolved
Hide resolved
gamepro65
force-pushed
the
cdrury/loggerFix
branch
from
ec58f03
to
6e6a62d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update sessionParams to include the new logger instance
Resolves: #1279