Migrate to modern AGP variants APIs #1443
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrodbx
force-pushed
the
jrod/2024-02-17/agp8-variants
branch
10 times, most recently
from
4706481
to
240ad91
Compare
TWiStErRob
reviewed
May 23, 2024
paparazzi-gradle-plugin/src/main/java/app/cash/paparazzi/gradle/PaparazziPlugin.kt
Show resolved
Hide resolved
TWiStErRob
reviewed
May 23, 2024
paparazzi-gradle-plugin/src/test/java/app/cash/paparazzi/gradle/PaparazziPluginTest.kt
Show resolved
Hide resolved
paparazzi-gradle-plugin/src/main/java/app/cash/paparazzi/gradle/PaparazziPlugin.kt
Show resolved
Hide resolved
jrodbx
force-pushed
the
jrod/2024-02-17/agp8-variants
branch
from
240ad91
to
a1f02ea
Compare
kevinzheng-ap
approved these changes
May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1136.
Moves the Android build stuff to the AndroidComponentsExtension#onVariants API. Also, cleans up the boutique logic around querying resource folder locations and improves lazy task wiring.