Removes requirement to render entire device Screen #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since there were significant structural changes I've updated this PR based on the latest master branch. Thanks for your feedback, @liutikas, I've resolved your comments since the files have moved, but I did add the requested comments. |
|
@jrodbx Anything preventing this from going in? |
|
It's on the queue for review, there's some other stuff I'd like to get in first + internal feature work to deliver. Hope to have a look soon. |
|
For what's worth androidx would love this feature to make 1.1 as well |
copybara-service bot
pushed a commit
to androidx/androidx
that referenced
this pull request
Oct 12, 2022
Apply cashapp/paparazzi#497 with some formatting tweaks to keep kt-lint happy. Test: N/A Bug: 253068501 Change-Id: Ieb1e3fa76fb4e1057e53a98fc6cbc81a848fba9f
jrodbx
approved these changes
Dec 13, 2022
paparazzi/paparazzi/src/test/java/app/cash/paparazzi/RenderingModeTest.kt
Outdated
Show resolved
Hide resolved
jrodbx
reviewed
Dec 13, 2022
paparazzi/paparazzi/src/main/java/app/cash/paparazzi/Paparazzi.kt
Outdated
Show resolved
Hide resolved
|
I'll follow up with a PR to migrate the test as a plugin test, but this is great. thanks! |
jrodbx
added a commit
that referenced
this pull request
Dec 13, 2022
jrodbx
added a commit
that referenced
this pull request
Dec 13, 2022
jrodbx
added a commit
that referenced
this pull request
Dec 13, 2022
jrodbx
added a commit
that referenced
this pull request
Dec 14, 2022
jrodbx
added a commit
that referenced
this pull request
Dec 14, 2022
This was referenced Dec 14, 2022
|
Should this work with Compose? |
|
We use it with Compose views without issues. If you're having a specific failure perhaps open an issue? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for
RenderMode.SHRINK, allowing you to make view-only screenshots without saving an entire device frame.