Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce resource visibility to BasicResourceItem #778

Merged
merged 5 commits into from
May 11, 2023
Merged

Introduce resource visibility to BasicResourceItem #778

merged 5 commits into from
May 11, 2023

Conversation

jrodbx
Copy link
Collaborator

@jrodbx jrodbx commented May 11, 2023 •
edited
Loading

Part of #524

Also, some minor cleanup to BasicResourceItem:

  • add license to top of file
  • order file by private vals, init block, overridden methods, private methods
  • store type as ordinal
  • move file to new internal resources namespace

@jrodbx jrodbx force-pushed the jrod/2023-05-10/reformat-basic-resource-item branch from ca6facc to 1be09f0 Compare May 11, 2023 01:12
@jrodbx jrodbx merged commit ace9578 into master May 11, 2023
26 checks passed
@jrodbx jrodbx deleted the jrod/2023-05-10/reformat-basic-resource-item branch May 11, 2023 02:06
@jrodbx jrodbx mentioned this pull request May 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luis-cortes luis-cortes luis-cortes approved these changes

@geoff-powell geoff-powell Awaiting requested review from geoff-powell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jrodbx @luis-cortes