Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port over AarSourceResourceRepository from tools/base/resource-repository #882

Merged
merged 1 commit into from
May 19, 2023

Conversation

jrodbx
Copy link
Collaborator

@jrodbx jrodbx commented May 19, 2023

Part of #524

cc: @kevinzheng-ap

Copy link
Collaborator

@kevinzheng-ap kevinzheng-ap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, need to fix Spotless

@jrodbx jrodbx force-pushed the jrod/2023-05-18/load-aar-sources branch from e88b5e8 to 4d8aff7 Compare May 19, 2023 07:34
@jrodbx
Copy link
Collaborator Author

jrodbx commented May 19, 2023

@kevinzheng-ap fyi, I commented out some test methods and assertions for now, until attr and styleable resources are working.

@jrodbx jrodbx force-pushed the jrod/2023-05-18/load-aar-sources branch from 4d8aff7 to 2e9e057 Compare May 19, 2023 08:00
@kevinzheng-ap
Copy link
Collaborator

kevinzheng-ap commented May 19, 2023

@kevinzheng-ap fyi, I commented out some test methods and assertions for now, until attr and styleable resources are working.

@jrodbx OK, attr and styleable resources are in my next PR, will then enable them.

@jrodbx jrodbx merged commit f36f499 into master May 19, 2023
14 checks passed
@jrodbx jrodbx deleted the jrod/2023-05-18/load-aar-sources branch May 19, 2023 15:21
@jrodbx jrodbx mentioned this pull request May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants