Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a sample Resources test #941

Merged
merged 1 commit into from
Jun 12, 2023
Merged

Conversation

jrodbx
Copy link
Collaborator

@jrodbx jrodbx commented Jun 9, 2023

To cover/highlight differences in resources loading

Part of #524

cc: @kevinzheng-ap

@jrodbx jrodbx force-pushed the jrod/2023-06-09/resources-test branch 2 times, most recently from 7a8b066 to 144a962 Compare June 9, 2023 22:46
@jrodbx jrodbx force-pushed the jrod/2023-06-09/resources-test branch from 144a962 to 6e6d2d0 Compare June 10, 2023 02:11
Comment on lines +40 to +45
addTextView(
Html.fromHtml(
resources.getString(R.string.string_name_html),
Html.FROM_HTML_MODE_LEGACY
)
)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, Html parsing 🎉

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea, however and unfortunately: this doesn't work yet (no longer chops off the substring past the closing tag, but doesn't honor bold/italics/etc.) despite it working in the IDE.

@jrodbx jrodbx merged commit 3d43289 into master Jun 12, 2023
14 checks passed
@jrodbx jrodbx deleted the jrod/2023-06-09/resources-test branch June 12, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants