Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Arity name comparison in BasicPluralsResourceItem #945

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Fix Arity name comparison in BasicPluralsResourceItem #945

merged 1 commit into from
Jun 13, 2023

Conversation

kevinzheng-ap
Copy link
Collaborator

@kevinzheng-ap kevinzheng-ap commented Jun 13, 2023 •
edited by jrodbx
Loading

Fix the bug that in BasicPluralsResourceItem, the name field in enum Arity should be used to match quantity rather than the name of enum constant.

cc @jrodbx

Part of #524

jrodbx
jrodbx approved these changes Jun 13, 2023
View reviewed changes
Copy link
Collaborator

@jrodbx jrodbx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wow, nice catch!

@jrodbx jrodbx merged commit 65ddac4 into cashapp:master Jun 13, 2023
7 checks passed
@jrodbx jrodbx deleted the fix-arity-name-comparison branch June 13, 2023 18:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrodbx jrodbx jrodbx approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kevinzheng-ap @jrodbx