Create event lambdas when property is set #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This has two nice effects. The first is that it defers a bunch of lambda creation until needed. If you toggle an event property we will create two lambda instances instead of one, but that should be rare. The second advantage is that likely makes the widget interface viable as an indirection the generated compose code can talk through. This will enable compose to talk directly to widgets or produce diffs. Or perhaps produce schema instances for testing.
JakeWharton
force-pushed
the
jw/event-sink/2021-04-09
branch
from
493c867
to
c1ef6f9
Compare
JakeWharton
commented
Apr 9, 2021
Comment on lines
+82
to
+90
| 3 -> { | ||
| val onClick: (() -> Unit)? = if (diff.value as Boolean) { | ||
| val event = Event(diff.id, 3, null); | ||
| { events(event) } | ||
| } else { | ||
| null | ||
| } | ||
| onClick(onClick) | ||
| } |
There was a problem hiding this comment.
This is the core change
saket
approved these changes
Apr 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has two nice effects. The first is that it defers a bunch of lambda creation until needed. If you toggle an event property we will create two lambda instances instead of one, but that should be rare. The second advantage is that likely makes the widget interface viable as an indirection the generated compose code can talk through. This will enable compose to talk directly to widgets (#14) or produce diffs. Or perhaps produce schema instances for testing (#1).