Inherit parent IDs during insertion #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are using intermediate nodes in the internal Compose tree which previously always sent -1 as the parent ID.
This includes src/main/kotlin and src/test/kotlin but excludes src/test/fixture/counter/build/generated/../stuff.kt which is generated and does not need to conform.
JakeWharton
commented
Apr 22, 2021
| @@ -37,6 +39,40 @@ import kotlin.test.assertEquals | |||
| import kotlin.test.fail | |||
|
|
|||
| class TreehouseCompositionTest { | |||
| @Test fun childrenInheritIdFromSyntheticParent() = runTest { | |||
There was a problem hiding this comment.
Note: This test is in a commit before the change to the generated code to assert that it works / does not break anything.
No need to be clever in the generated code. This does mean we need to switch to internal mutability, but it's a small price to pay for the generated code cleanup. Additionally, this is needed to support the forthcoming test output tree.
JakeWharton
force-pushed
the
jw/inherit-parent-id/2021-04-21
branch
from
1492a3a
to
d8e61e7
Compare
saket
approved these changes
Apr 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need to be clever in the generated code. This does mean we need to switch to internal mutability, but it's a small price to pay for the generated code cleanup. Additionally, this is needed to support the forthcoming test output tree.
Refs #1. Refs #14.