Check that autocommit is set to true before beginning a transaction (#…

…2291)
cashapp · Apr 15, 2021 · 839b1c8 · 839b1c8
1 parent 80a9cb0
commit 839b1c8
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/drivers/jdbc-driver/src/main/kotlin/com/squareup/sqldelight/sqlite/driver/JdbcDriver.kt b/drivers/jdbc-driver/src/main/kotlin/com/squareup/sqldelight/sqlite/driver/JdbcDriver.kt
@@ -70,6 +70,12 @@ abstract class JdbcDriver : SqlDriver, ConnectionManager {
   }
 
   override fun Connection.beginTransaction() {
+    check(autoCommit) {
+      """
+      Expected autoCommit to be true by default. For compatibility with SQLDelight make sure it is
+      set to true when returning a connection from [JdbcDriver.getConnection()]
+      """.trimIndent()
+    }
     autoCommit = false
   }