Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for pg RIGHT/FULL [OUTER] JOIN #5086

Open
de-luca opened this issue Mar 22, 2024 · 1 comment · May be fixed by #5136
Open

Add support for pg RIGHT/FULL [OUTER] JOIN #5086

de-luca opened this issue Mar 22, 2024 · 1 comment · May be fixed by #5136
Labels

Comments

@de-luca
Copy link
Contributor

de-luca commented Mar 22, 2024

Description

Support for RIGHT and FULL joins would be great to have maximum flexibility without relying on hacks using LEFT JOIN or UNION.

@griffio
Copy link
Contributor

griffio commented Mar 25, 2024

Currently, this is limited by the implementation of JoinClauseMixin in sql-psi project https://github.com/AlecKazakova/sql-psi/blob/6ea26b938a617c74e0b12c782dae9e9a8cc62537/core/src/main/kotlin/com/alecstrong/sql/psi/core/psi/mixins/JoinClauseMixin.kt#L65

The base SQL implementation only supports resolving columns with LEFT joins as not all databases e.g MySql support FULL joins.

🛠️ Changing the PostgreSql grammar is possible, but making a change in sql-psi to allow adding more joins clauses needs some thinking about 🤔

It would be beneficial to allow different vendor joins, as the latest version of Sqlite supports RIGHT and FULL joins. MySql supports RIGHT joins and PostgreSql supports additionally LATERAL.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants