Update JoinClauseMixin to support more ANSI SQL joins #616
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦶Initial step to support cashapp/sqldelight#5086
Add Ansi Sql join operators
RIGHT
andFULL
e.g Now supported in https://www.sqlite.org/releaselog/3_39_0.htmlLATERAL
modifier not included, as works in two different ways (table/subquery and join) and should be implemented as a separate featureThese are added as forward declarations in the
SqlLexer.flex
that are needed for dialects to override🏰 Keep core grammar with
LEFT
joinThis allows the existing dialects to work with
LEFT
join and enables dialects to addRIGHT
,FULL
where supported, e.g PostgreSql and latest Sqlite dialecte.g Postgresql.bnf would override the core
join_operator
and addsright_join_operator
📸 Tested snapshot build with SqlDelight branch as this appears to work