Support dependencies between sqldelight modules #1229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlecKazakova
force-pushed
the
astrong/2019-02-23/module-dependencies
branch
from
679179f
to
9f957ec
Compare
JakeWharton
approved these changes
Feb 24, 2019
| throw IllegalStateException("Found a circular dependency in $project with database $name") | ||
| } | ||
| recursionGuard = true | ||
|
|
||
| val packageName = requireNotNull(packageName) { "property packageName must be provided" } |
There was a problem hiding this comment.
I'm a bit uneasy about having code between setting the value to true and the try/finally. Can we move this to the top of the function?
AlecKazakova
force-pushed
the
astrong/2019-02-23/module-dependencies
branch
from
9f957ec
to
c70451c
Compare
AlecKazakova
changed the base branch from
astrong/2019-02-23/better-gradle-dsl
to
master
AlecKazakova
force-pushed
the
astrong/2019-02-23/module-dependencies
branch
from
c70451c
to
a5764cc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #502